Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default info color to cyan #18442

Merged
merged 1 commit into from
Sep 12, 2016
Merged

change default info color to cyan #18442

merged 1 commit into from
Sep 12, 2016

Conversation

KristofferC
Copy link
Member

It is for me almost illegible with the standard blue on black.

Before:
image

After:

image

On white:

image

@ViralBShah
Copy link
Member

I really want this in. What OS is your screenshot on? Can you do it on Linux, Windows and Mac - all? I find the blue significantly worse on windows.

@ViralBShah
Copy link
Member

ViralBShah commented Sep 11, 2016

Related #2088 #12753

@KristofferC
Copy link
Member Author

It is not about OS. Many terminals in Ubuntu tweak with the default color palette. For example with gnome-terminal:

selection_076

I run urxvt un Ubuntu above without any modification to Xresources and the colors look similar to Windows.

@ViralBShah
Copy link
Member

Ok - I guess windows is the real one I wanted to see it on, but I suspect nothing can be as bad on the eyes as the blue.

@KristofferC
Copy link
Member Author

The after picture is likely what it will look like since the way my settings are now replicates the windows cmd window. I can post a screenshot to make sure next time I am on the windows machine.

@tkelman
Copy link
Contributor

tkelman commented Sep 11, 2016

also test in powershell where the default background is blue

@twadleigh
Copy link
Contributor

While you're at it, would you consider making the default warning color yellow? I thought about making these changes (info as cyan, warn as yellow) when I made the PR to make these configurable, but didn't want to push my luck getting it accepted.

@KristofferC
Copy link
Member Author

KristofferC commented Sep 12, 2016

Powershell + windows cmd:

image

@KristofferC
Copy link
Member Author

KristofferC commented Sep 12, 2016

@twadleigh I rather keep as little in this PR as possible for the same reasons you had :P

@ViralBShah
Copy link
Member

This is looking good everywhere, and is easy to revert if necessary.

@ViralBShah ViralBShah merged commit 9b83cd6 into master Sep 12, 2016
@KristofferC KristofferC deleted the kc/end_of_all_terror branch September 12, 2016 11:21
@ViralBShah ViralBShah added this to the 0.5.0 milestone Sep 12, 2016
@tkelman tkelman modified the milestones: 0.5.x, 0.5.0 Sep 12, 2016
@tkelman
Copy link
Contributor

tkelman commented Sep 12, 2016

in what world is this release blocking? you can already get this with environment variables. I'll backport it for 0.5.1 once people have used it on master for a while if no one complains, but it's not getting rushed into 0.5.0.

@StefanKarpinski
Copy link
Member

Agreed. Making this release blocking is insane.

@eschnett
Copy link
Contributor

This is worthy a news item since it's so clearly visible. Also, I'm probably not alone in disliking this change, so people will be happy about pointers to the documentation telling them how to choose colours locally.

I don't assume that Julia could easily find out whether the background colour is light or dark?

@KristofferC
Copy link
Member Author

I was thinking about a news entry. I feel it is almost impossible to pick a color out of the 8-16 ones that all terminals support that everyone will like. The experience on powershell and cmd right now is so poor that I still think this change is good. Would be good if we could identify if the terminal supports 256 colors and use a light blue for those cases...

@KristofferC
Copy link
Member Author

Will add an entry in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants