-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default info color to cyan #18442
Conversation
I really want this in. What OS is your screenshot on? Can you do it on Linux, Windows and Mac - all? I find the blue significantly worse on windows. |
Ok - I guess windows is the real one I wanted to see it on, but I suspect nothing can be as bad on the eyes as the blue. |
The after picture is likely what it will look like since the way my settings are now replicates the windows cmd window. I can post a screenshot to make sure next time I am on the windows machine. |
also test in powershell where the default background is blue |
While you're at it, would you consider making the default warning color yellow? I thought about making these changes (info as cyan, warn as yellow) when I made the PR to make these configurable, but didn't want to push my luck getting it accepted. |
@twadleigh I rather keep as little in this PR as possible for the same reasons you had :P |
This is looking good everywhere, and is easy to revert if necessary. |
From googling a bit, it seems that a lot of things uses yellow for warning: https://kate-editor.org/wp-content/uploads/2012/11/messages1.png etc |
in what world is this release blocking? you can already get this with environment variables. I'll backport it for 0.5.1 once people have used it on master for a while if no one complains, but it's not getting rushed into 0.5.0. |
Agreed. Making this release blocking is insane. |
This is worthy a news item since it's so clearly visible. Also, I'm probably not alone in disliking this change, so people will be happy about pointers to the documentation telling them how to choose colours locally. I don't assume that Julia could easily find out whether the background colour is light or dark? |
I was thinking about a news entry. I feel it is almost impossible to pick a color out of the 8-16 ones that all terminals support that everyone will like. The experience on powershell and cmd right now is so poor that I still think this change is good. Would be good if we could identify if the terminal supports 256 colors and use a light blue for those cases... |
Will add an entry in a while. |
add NEWS entry for change in default color for info messages [#18442]
It is for me almost illegible with the standard blue on black.
Before:
After:
On white: