-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libgit2 path issues #18724
Comments
We should attempt to identify which of these limitations come from the c library and which are self inflicted bugs. Command line git lets you use abs paths but errors if you try to add something that's not inaide the current repo, right? |
Good find. I agree with you and think we should try to do some obvious manipulations before sending to the c library in the bindings instead of needing every user to test and work around the same issues (or all hit this problem if they don't) |
There are a couple of issues with the current implementation (or the docs) of
LibGit2
:Functions like
LibGit2.add!
take afiles
argument, which must be (as per here)Since there are no docs for the functions
libgit2/index.jl
that's a bit of a usability problem which e.g. causedPkgDev.tag
to not work on Windows (see JuliaLang/PkgDev.jl#28).I'd suggest to either
or
I can look into preparing a PR for either of the above if someone decides what to do, but maybe someone more familiar with the codebase would be better suited to do that.
cc @tkelman
The text was updated successfully, but these errors were encountered: