Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalize the use of ! in various linear algebra functions #1946

Closed
ViralBShah opened this issue Jan 8, 2013 · 2 comments
Closed

Rationalize the use of ! in various linear algebra functions #1946

ViralBShah opened this issue Jan 8, 2013 · 2 comments

Comments

@ViralBShah
Copy link
Member

As noted in #907 the usage of ! should be consistent in all the linear algebra functions.
@ViralBShah
Copy link
Member Author

Some other things that came up:

  1. isposdef! is not really useful, since after checking a matrix for being positive definite, the matrix is not available for further use. Instead chol! could be used.
  2. We may want the user facing linear algebra routines to throw exceptions instead of errors. The Factorization interface can actually return the LAPACK error codes.

@ViralBShah
Copy link
Member Author

We are keeping the current usage as it is quite popular, and the usage is consistent.

@stevengj stevengj mentioned this issue Sep 22, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ViralBShah