rename isa to instanceof?

[StefanKarpinski]

It should be more familiar to Python programmers and potentially less confusing?

[quinnj]

Java also has instanceof, though it it used infix.

[KristofferC]

Instance sounds more like it is related to classes to me. Personally I like isa.

[yuyichao]

Would be isinstance for python. What's the confusion about the current one? (especially since is is deprecated now)

[StefanKarpinski]

Just witnessed a room full of confusion about what isa meant, so I thought I'd throw it out there.

[ararslan]

Do you know what about it they found confusing? It's always seemed quite clear to me.

[johnmyleswhite]

I think people often confuse isa with <:. I've done it myself a bunch of times.

[StefanKarpinski]

Deprecation of is definitely helps. Maybe it's just fine; people do seem to confuse it with <:. I'm not sure what the solution is. I think that :: and <: are fairly clear (although sometimes those get confused too). Maybe there's nothing to be done here.

[yuyichao]

What I do want from time to time is an operator for isa.

[JeffBezanson]

I find instanceof a bit too long.

[pabloferz]

If isa were also an operator (as in is, for example), that probably would help to avoid for some people to get confused, with the benefit of being easy to type. E.g.

a = 1
if a isa Int
    #do something
end

which, seems pretty clear to me.

[simonbyrne]

I like the fact that most predicates begin with is.

[JeffreySarnoff]

In another context, I used is followed by a kind of in anagram form:

fourtytwo = "42"
isako( fourtytwo, Integer )

[oxinabox]

I can never remember the name of the isa function.

I tend to write: foo |> typeof <: Integer
which is I guess pseudo-infix.

[iamed2]

Just witnessed a room full of confusion about what isa meant, so I thought I'd throw it out there.

Was the confusion about the behaviour or just how to read the function name? I wouldn't mind a change to is_a (a few people at Invenia dislike the "underscore case except sometimes not" rule).

[StefanKarpinski]

I dunno. Probably not worth changing. I agree that the underscore rule can be annoying. @JeffBezanson hates underscores :P. I would be ok with using underscores and then just trying to delete all names that have them in Base over time.

[ararslan]

I've implemented the infix operator version of isa in #19677, as discussed here by Yichao and Pablo, if anyone's interested in taking a look.