Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Range to AbstractRange? #21901

Closed
nalimilan opened this issue May 16, 2017 · 5 comments
Closed

Rename Range to AbstractRange? #21901

nalimilan opened this issue May 16, 2017 · 5 comments
Labels
arrays [a, r, r, a, y, s]

Comments

@nalimilan
Copy link
Member

Range is one of the very few Base abstract types which do not contain "Abstract" in their names. The only other case that comes to my mind is number types (Integer, Real...), which have been granted an exception. Should we rename it to AbstractRange? This would be clearer IMHO, since Range can intuitively be understood as the default range type (equivalent to Array vs. AbstractArray).
@kshyatt kshyatt added the collections Data structures holding multiple items, e.g. sets label May 16, 2017
@nalimilan
Copy link
Member Author

Any opposition to this change? If not, I'll make a PR.

@StefanKarpinski
Copy link
Member

It was once called this and we changed it. You may want to look for the discussion around that change before going ahead with this.

@mbauman
Copy link
Member

mbauman commented Aug 29, 2017

I think you may be thinking of the Ranges -> Range change (#6326). It doesn't look like they were ever called AbstractRange.

@StefanKarpinski
Copy link
Member

Right, I was misremembering. At least we're not going in circles :)

@nalimilan
Copy link
Member Author

Only in zigzags... I'll make a PR then.

@mbauman mbauman added arrays [a, r, r, a, y, s] and removed collections Data structures holding multiple items, e.g. sets labels Aug 30, 2017
@nalimilan nalimilan mentioned this issue Sep 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StefanKarpinski @mbauman @kshyatt @nalimilan