-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cholfact[!] does not respect the uplo character #22187
Comments
I will push a fix later. |
This happened in the process of requiring that input is strict Hermitian either by value or |
Yea, that's what I planned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cholfact
andcholfact!
has an optionaluplo
input to only consider the upper/lower part of the matrix, but this is not taken into account when checkingishermitian()
. For instance:This faulty behavior is actually also tested(!).
The text was updated successfully, but these errors were encountered: