-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually decouple special function (openspecfun) from base #22390
Comments
This is on my to-do list, we just need a pure Julia implementation of |
Regarding a Julia implementation, ref discussion in #22004 |
BTW there is https://github.com/JuliaLang/openlibm/blob/1581174c85f7b645b15ba1ac1c3a98fb601f0fe7/src/e_rem_pio2.c in openlibm which exactly the same as the openspecfun code .... but perhaps to call it some minor modification would need to be made to the C lib ? I'm not sure why we are calling the openspecfun version anyways |
If I'm not mistaken, it's not standard to have that in system libms. Since we allow building with a libm other than openlibm but we don't allow any special function library other than openspecfun, we're likely calling it from openspecfun instead to ensure the function is always available. |
This doesn't actually affect any Base APIs, does it? If so, it's a non-breaking change and can be removed from the 1.0 milestone. |
Removing a library that people have been calling into and assuming gets shipped with julia binaries sounds breaking to me. |
Yeah, it's definitely breaking for anyone who could be |
SpecialFunctions
relies onopenspecfun
from Base. LikeFFTW
would the next logical step be to haveSpecialFunctions
actually carry out the build process instead of in baseThe text was updated successfully, but these errors were encountered: