Inlining cost model: don't count :invokes that throw
#22732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
reviewed
Jul 10, 2017
base/inference.jl
Outdated
| @@ -4649,7 +4649,12 @@ function statement_cost(ex::Expr, src::CodeInfo, mod::Module, params::InferenceP | |||
| end | |||
| return plus_saturate(argcost, params.inline_nonleaf_penalty) | |||
| elseif head == :foreigncall || ex.head == :invoke | |||
There was a problem hiding this comment.
Unrelated but head == :invoke ? (Or ===)
The throw is not typically part of the standard runtime cost of the function.
timholy
force-pushed
the
teh/inlining_throw
branch
from
7926163
to
62f6d78
Compare
|
@nanosoldier |
|
Something seems wrong with nanosoldier, possibly JuliaCI/BaseBenchmarks.jl#83. I've checked locally; there are 5 reproducible regressions, the worst of which is 20%. There are also 5 reproducible improvements, of which some are nearly 10x. Since 10x beats 1.2x, I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The throw is not typically part of the standard runtime cost of the function. This should fix the performance concern with #20005, which turns out to be an inlining difference.