Undeprecate +/- for UniformScaling and Number #23923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
anj/uniform
branch
from
efbea46
to
57fe829
Compare
|
Fixes #22880? |
fredrikekre
reviewed
Sep 28, 2017
NEWS.md
Outdated
| @@ -105,6 +105,10 @@ Language changes | |||
| of the `:quote` expression head (though `:quote` `Expr`s are still used for quoted | |||
| expressions) ([#23885]). | |||
|
|
|||
| * The + and - methods for Number and UniformScaling are not ambiguous anumore since + and - | |||
There was a problem hiding this comment.
Code quote +, -, Number and UniformScaling?
anumore -> anymore
andreasnoack
force-pushed
the
anj/uniform
branch
from
57fe829
to
aa7808c
Compare
Just added a comment in that issue |
andreasnoack
force-pushed
the
anj/uniform
branch
from
aa7808c
to
68ebf55
Compare
fredrikekre
approved these changes
Sep 28, 2017
StefanKarpinski
approved these changes
Sep 29, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #22932, these a no longer ambiguous and we can therefore remove the deprecations.