Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go gentle into that good night, full #24250

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Oct 20, 2017

Dylan Thomas would much admire how you have raged, raged against the dying of the light, full. But even he would insist that close of day has come. So go gentle into that good night, full. And when you do, please take JuliaLang/LinearAlgebra.jl#229, JuliaLang/LinearAlgebra.jl#231, and #18850 with you.

(... in case that reference is too obscure, this pull request finally deprecates full, and closes JuliaLang/LinearAlgebra.jl#229, JuliaLang/LinearAlgebra.jl#231, and #18850. Best!)

@Sacha0 Sacha0 added arrays [a, r, r, a, y, s] deprecation This change introduces or involves a deprecation labels Oct 20, 2017
@Sacha0 Sacha0 added this to the 1.0 milestone Oct 20, 2017
@StefanKarpinski
Copy link
Member

That's one hell of a deprecation.

@Sacha0
Copy link
Member Author

Sacha0 commented Oct 22, 2017

Updated with PR# in NEWS.md. Absent objections or requests for time, I plan to merge this deprecation in the next day or two. Best!

@andreasnoack
Copy link
Member

It looks like there is still an import full in linalg.jl which needs to go. No idea why AppVeyor times out.

@Sacha0
Copy link
Member Author

Sacha0 commented Oct 22, 2017

It looks like there is still an import full in linalg.jl which needs to go.

https://www.youtube.com/watch?v=Tim5nU3DwIE

@Sacha0 Sacha0 merged commit c5faf80 into JuliaLang:master Oct 24, 2017
@Sacha0 Sacha0 deleted the goodnightfull branch October 24, 2017 16:08
@Sacha0
Copy link
Member Author

Sacha0 commented Oct 24, 2017

Thanks all! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays [a, r, r, a, y, s] deprecation This change introduces or involves a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a name other than full for returning original array from a factorization
4 participants