Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate intset to bitset #24282

Merged
merged 2 commits into from
Oct 26, 2017
Merged

deprecate intset to bitset #24282

merged 2 commits into from
Oct 26, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Oct 23, 2017

#24263 / #24281 reminded me that renaming IntSet to BitSet received reasonable support in #20512. This pull request provides that rename. Best!

@Sacha0 Sacha0 added deprecation This change introduces or involves a deprecation triage This should be discussed on a triage call labels Oct 23, 2017
@Sacha0 Sacha0 force-pushed the bitset branch 2 times, most recently from d5f23af to 06d8633 Compare October 23, 2017 04:33
@StefanKarpinski StefanKarpinski added this to the 1.0 milestone Oct 26, 2017
@StefanKarpinski StefanKarpinski removed the triage This should be discussed on a triage call label Oct 26, 2017
@StefanKarpinski StefanKarpinski merged commit dbb3cf0 into JuliaLang:master Oct 26, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Oct 26, 2017

Thanks all! :)

@Sacha0 Sacha0 deleted the bitset branch October 26, 2017 18:46
@rfourquet
Copy link
Member

Personally I'm not conviced by this change, I don't really see the strong connection to bits. Sure it can be used to reference bits, but the interface of it is to be an AbstractSet which can store only positive integers: what is specific to bits in that? At least it would be useful to explain the connection to bits in the docstring. But I admit I know only bitset in C++, where this represents a fixed number of bits with a specific interface (different from sets), so I may miss the precedent from other languages. On a side note, I had an in-progress branch where I explored storing any Int in IntSet, but don't know yet if the overhead would be minimal enough for base...

@ararslan ararslan mentioned this pull request Nov 1, 2017
Merged
@rfourquet rfourquet mentioned this pull request Dec 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@Sacha0 @rfourquet @fredrikekre @StefanKarpinski