-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Base.propertynames(x), analogous to fieldnames(typeof(x)) #25311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
added
needs docs
Documentation for this change is required
needs news
A NEWS entry is required for this change
needs tests
Unit tests are required for this change
labels
Dec 29, 2017
stevengj
changed the title
inPropertynames
RFC: Base.propertynames(x), analogous to fieldnames(typeof(x))
Dec 29, 2017
…nternal names that shouldn't normally show up in tab completion
stevengj
force-pushed
the
propertynames
branch
from
January 11, 2018 21:35
c53b166
to
29933b5
Compare
stevengj
added
triage
This should be discussed on a triage call
and removed
needs docs
Documentation for this change is required
needs news
A NEWS entry is required for this change
needs tests
Unit tests are required for this change
labels
Jan 11, 2018
JeffBezanson
approved these changes
Jan 17, 2018
Seems reasonable to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #24960 and #1974, it would be useful to have a
propertynames(x)
function, analogous tofieldnames(typeof(x))
, that returns (if possible!) an array of valid symbolss
for passing togetproperty(x,s)
orx.s
. This is especially useful for REPL tab completion.Note that, unlike
fieldnames
, it needs to take an instance rather than a type, since in many cases the property names (e.g. of a dataframe or Python object) will depend on the instance.Questions:
LinAlg.LU
, object, maybe it should return[:L,:U,:p,:P]
but not "internal" fields like:ipiv
?userpropertynames
?Base.propertynames
be exported, likefieldnames
?Answers:
propertynames(x, private=false)
:propertynames(x)
by default may only return user-visible (documented) properties, but the optionalprivate=true
argument can indicate that all valid properties are requested. Tab completion usesprivate=false
.getproperty
is not exported, I decided not to exportpropertynames