Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel should disallow isempty #27754

Closed
Keno opened this issue Jun 24, 2018 · 2 comments
Closed

Channel should disallow isempty #27754

Keno opened this issue Jun 24, 2018 · 2 comments

Comments

@Keno
Copy link
Member

Keno commented Jun 24, 2018

It's a mutable iterator without lookahead. We cannot support isempty on this iterator. We should disallow it instead (and perhaps point the user to isready). At the moment, calling isempty consumes an element of the Channel, which is problematic.
@haampie
Copy link
Contributor

haampie commented Jun 24, 2018

Related: #27412

@laborg
Copy link
Contributor

laborg commented Feb 6, 2022

Now that isempty isn't mutating the channel anymore (#36641) this issue can closed, right?

@vtjnash vtjnash closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@haampie @vtjnash @Keno @laborg