Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complex function branch cut behaviour #2875

Closed
simonbyrne opened this issue Apr 17, 2013 · 6 comments
Closed

Fix complex function branch cut behaviour #2875

simonbyrne opened this issue Apr 17, 2013 · 6 comments

Comments

@simonbyrne
Copy link
Contributor

I've added a bunch of tests (#2845) for the branch cut problems for the functions of complex variables. Currently, some of these tests fail, and so are excluded from make testall (and hence travis), however they can be run manually by make test-complex.

The C99 standard specifies the behaviour of some functions, though is ambiguous for ^ (cpow).

Kahan provides background, as well as some algorithms.

@JeffBezanson
Copy link
Sponsor Member

Have you figured out which functions have problems, or is it all of them?

@simonbyrne
Copy link
Contributor Author

Yes, it seems that every function raises at least one error.

@JeffBezanson
Copy link
Sponsor Member

I see you did meticulous testing for signed zeros, which is great, but I'm wondering where some of the answers come from. See comments on 3ef1d4d

@ViralBShah
Copy link
Member

Perhaps it would be good to also include the source for every test in complex.jl? That by itself will be valuable.

@simonbyrne
Copy link
Contributor Author

I don't know if it needs to go in the source, but the behaviour should certainly be specified in the documentation.

@JeffBezanson
Copy link
Sponsor Member

@jiahao 's branch merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants