-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix complex function branch cut behaviour #2875
Comments
Have you figured out which functions have problems, or is it all of them? |
Yes, it seems that every function raises at least one error. |
I see you did meticulous testing for signed zeros, which is great, but I'm wondering where some of the answers come from. See comments on 3ef1d4d |
Perhaps it would be good to also include the source for every test in |
I don't know if it needs to go in the source, but the behaviour should certainly be specified in the documentation. |
@jiahao 's branch merged. |
I've added a bunch of tests (#2845) for the branch cut problems for the functions of complex variables. Currently, some of these tests fail, and so are excluded from
make testall
(and hence travis), however they can be run manually bymake test-complex
.The C99 standard specifies the behaviour of some functions, though is ambiguous for
^
(cpow
).Kahan provides background, as well as some algorithms.
The text was updated successfully, but these errors were encountered: