one(::CartesianIndex) => oneunit(::CartesianIndex) #29442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xref #26284 |
|
I think this is a good approach to deprecations for now. |
timholy
force-pushed
the
teh/oneunit_cartindex
branch
from
25ebb98 to
27a45f5
Compare
|
I put the NEWS in the "deprecated" section even though there is no depwarn for now. If there are no objections I'll merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we should deprecate
one(::CartesianIndex), but I am uncertain about the strategy for deprecations in 1.x. I tried to set it up so that it will be easy to do when the time comes, but I can change this given feedback.