-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop exporting HTML and Text from Base #29841
Comments
It might be possible to remove these exports before 2.0 but only if no one in any package is using them. |
The |
It is used but it is explicitly imported so removing the export wouldn't be breaking. |
There are other packages that use |
Seems sneaky and kind of crappy to go from exported—and therefore official API—to unexported, taking advantage of the fact that someone else was a good end-user explicitly and imported it, only to then turn around and break their code by deleting or moving what used to be an official API. |
Don't we have femtocleaner for precisely these types of trivial substitutions? |
The ASCII colors required Text in order to render correctly on I Julia IIRC, but I can double check. Just remove the export and I'll make sure to Base. it ASAP. |
If you take semver seriously, then this is simply not an option until Julia 2.0. |
I'd also add |
I second that. Public packages are not the only Julia code out there. |
Believe me, I hate that we export this as much as anyone, but we do, now we have to live with it. |
I didn't grok it at first, but now I think Anyway, I use If we want to drop |
Stop exporting HTML and Text from Base.
The
Text
one is pretty annoying since it's easy to clash with.The text was updated successfully, but these errors were encountered: