Adding rtol and atol for pinv and nullspace #29998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2018 02:56
sam0410
changed the title
|
Hi @andyferris, Sorry for the delay. I resolved your comment. Also there is some issue with the test/pinv tests. I will resolve them soon. |
added 2 commits
November 23, 2018 03:03
sam0410
changed the title
|
Hi @andyferris, can you please review this PR now? |
|
Hi @simonbyrne, I made the changes. |
|
Oh ! Sorry, I didn't make that part clear. |
|
No problem, I figured it was easier for me to make the changes than keep asking you for them. Thanks! |
|
This can be backported to 1.1 since it also contains the NEWS item for #29926. |
KristofferC
pushed a commit
that referenced
this pull request
Dec 12, 2018
* Add code for rtol and atol * add tests * resolve comment * fix typo * fix tests * add news.md item * Not deprecated yet. * Tweak docs slightly * typo from diff [skip ci] (cherry picked from commit 5b2e3e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as discussed in the PR #29926