Update libunwind to 1.3.1 #30724
Merged
Update libunwind to 1.3.1 #30724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
building
|
Elliot also mentioned that it would be good to know whether the patch is still necessary at all. Perhaps DWARF-based unwinding, which is the default for ARM in libunwind, is sufficient now. |
|
@yuyichao do you think that the old libunwind patch is still necessary? |
|
AFAIK nothing has changed about dwarf on arm. It's not what the platform use so there's just no reason to use it. |
Co-authored-by: Yichao Yu <yyc1992@gmail.com>
ararslan
force-pushed
the
aa/libunwind-1.3.1
branch
from
b2e8ca0 to
e2dc372
Compare
|
Perfect, thanks. I've updated the patch file with the contents of the Arch patch, modified to apply to libunwind 1.3.1. I've added Yichao as a co-author for the commit since the patch was his work. |
yuyichao
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to drop all of our patches except for one: the one that prefers extbl-based unwinding on ARM. It appears that patch will need to be redone atop current libunwind. @yuyichao, would you be able to help out with that, since you authored the original patch?