Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

givens does not work with integer vectors #32388

Closed
hurak opened this issue Jun 21, 2019 · 1 comment
Closed

givens does not work with integer vectors #32388

hurak opened this issue Jun 21, 2019 · 1 comment

Comments

@hurak
Copy link

hurak commented Jun 21, 2019

The function givens (Julia v1.1.1) does not work properly with vectors with integer arguments. An example code is below:

using LinearAlgebra
x = [3,4]
G,r = givens(x,1,2)

it returns

ERROR: MethodError: no method matching givensAlgorithm(::Int64, ::Int64)
Stacktrace:
 [1] givens(::Int64, ::Int64, ::Int64, ::Int64) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/LinearAlgebra/src/givens.jl:276
 [2] givens(::Array{Int64,1}, ::Int64, ::Int64) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/LinearAlgebra/src/givens.jl:317
 [3] top-level scope at none:0

If instead the vector x contains floats, there are no problems:

x = [3.0,4.0]
G,r = givens(x,1,2)

yielding

(LinearAlgebra.Givens{Float64}(1, 2, 0.6, 0.8), 5.0)
@andreasnoack
Copy link
Member

This was fixed in #31853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants