-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEWS entry for sprand changes #32554
Comments
something like this?
|
I think this is fine. I think if someone wants to reproduce the old stream, they should use the older released version of Julia. My view is that we don't want to put it in the NEWS. |
I think that in general, it could be emphasized somewhere in the docs that unless explicitly stated otherwise, random APIs in Base and the standard libraries can break reproducibility of random streams/bits without deprecation or prior notice. |
Ermm.. I don't understand if you are ok with the proposed addition to NEWS or not. 😕 |
What? Why would we not put changes to random number sequences in NEWS? That is definitely a "minor change". |
Sorry for the ambiguity. My proposal was to put the following in the NEWS: The sprand function is now 2 to 5 times faster ([#30494]). As a consequence of this change, the random stream of matrices produced with |
It's fine for me either way, but I think it is pretty nice that you can essentially just cut&paste the old code and have a working |
Why not mention it in the documentation of the function? That's the place I would look into if I wanted the old behaviour - not in the NEWS. I guess it could be in the NEWS too, but may stop working with 2.0. |
Imo just point out the change. There is no need to say that one can get the old behavior by using the old code for every change, that is always true. |
Another option is to put the link to the blob with the code for the old stream in the description of PR 30494, and not mention how to get the old stream in the news. The interested user would anyway first go to the PR, where you can also find further justifications in the discussion. The |
Good idea, I did just that. |
This change #30494 needs NEWS.
The text was updated successfully, but these errors were encountered: