Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows buildbots failing due to "hard kill repl test"" #33787

Closed
musm opened this issue Nov 8, 2019 · 6 comments
Closed

Windows buildbots failing due to "hard kill repl test"" #33787

musm opened this issue Nov 8, 2019 · 6 comments
Labels
ci Continuous integration system:windows Affects only Windows

Comments

@musm
Copy link
Contributor

musm commented Nov 8, 2019

I've seen this error now in two of my PRs
e.g.: https://build.julialang.org/#/builders/32/builds/5930/steps/2/logs/stdio

Error in testset REPL:
Error During Test at D:\buildbot\worker-tabularasa\tester_win64\build\share\julia\test\testdefs.jl:22
  Got exception outside of a @test
  LoadError: LoadError: "hard kill repl test"
@JeffBezanson JeffBezanson added ci Continuous integration system:windows Affects only Windows labels Nov 8, 2019
@vtjnash
Copy link
Member

vtjnash commented Nov 8, 2019

It feels like it started about 3 days ago with https://build.julialang.org/#/builders/65/builds/5581 / https://build.julialang.org/#/builders/32/builds/5890 and is now affecting many builds?

Seeing as how that is a build of a PR (#33770) that changed the line of code being tested here, it seems perhaps related.

@musm
Copy link
Contributor Author

musm commented Nov 10, 2019

@rfourquet maybe you have some ideas why we are seeing this ?

@rfourquet
Copy link
Member

I have no idea but will have a look...

@rfourquet
Copy link
Member

I stil don't understand the error (I don't know where the "hard kill repl test" comes from), but I would be surprised if the problem comes from #33770: all the tests were passing in this PR before merging, and as an experiment, I reverted it in #33805 (on top of an unrelated PR), and there the tests still don't pass (and not only on windows by the way, e.g. https://build.julialang.org/#/builders/22/builds/6746).

@rfourquet rfourquet removed the system:windows Affects only Windows label Nov 11, 2019
@musm
Copy link
Contributor Author

musm commented Nov 11, 2019

Thanks for taking a look.
https://github.com/JuliaLang/julia/blob/master/stdlib/REPL/test/repl.jl#L20
https://github.com/JuliaLang/julia/blob/master/stdlib/REPL/test/repl.jl#L32
it looks like a 'kill_timer" issue in one of the tests calling the function

@JeffBezanson JeffBezanson added the priority This should be addressed urgently label Nov 12, 2019
@JeffBezanson JeffBezanson added system:windows Affects only Windows and removed priority This should be addressed urgently labels Jan 21, 2020
@musm
Copy link
Contributor Author

musm commented Jul 23, 2020

I'm not seeing this anymore

@musm musm closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration system:windows Affects only Windows
Projects
None yet
Development

No branches or pull requests

4 participants