Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic 5 arg mul! promotes Int32 to Int64 #35163

Closed
haampie opened this issue Mar 19, 2020 · 0 comments · Fixed by #35164
Closed

Generic 5 arg mul! promotes Int32 to Int64 #35163

haampie opened this issue Mar 19, 2020 · 0 comments · Fixed by #35164
Labels
linear algebra Linear algebra

Comments

@haampie
Copy link
Contributor

haampie commented Mar 19, 2020 •
edited
Loading 

using LinearAlgebra
julia> mul!(rand(Int32, 4), rand(Int32, 4, 4), rand(Int32, 4), Int32(4), Int32(5))
ERROR: InexactError: trunc(Int32, -138749043280184131)

Like Float32 shoudn't use Float64 arithmetic internally, Int32 should just compute in Int64 throughout as well I would assume.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix generic mul accidental type promotion Int32 -> Int64 haampie/julia
2 participants
@haampie @dkarrasch