allow redirect_std* to devnull (#36136)
#36146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
tkf
reviewed
Jun 7, 2020
Keno
reviewed
Jun 8, 2020
|
Let's get this merged soon if there are no more review comments! |
|
bump it after a week of silence |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
oxinabox
added a commit
to oxinabox/julia
that referenced
this pull request
Oct 6, 2020
ViralBShah
added a commit
that referenced
this pull request
Dec 6, 2020
* Add missing news from #36146 * qualify DevNull * say devnull * Update NEWS.md Co-authored-by: Kristoffer Carlsson <kricarl@student.chalmers.se> Co-authored-by: Kristoffer Carlsson <kricarl@student.chalmers.se> Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #36136 partially.
The methods
redirect_std*(io::Base.DevNull)have been added. They redirect to"/dev/null"on non-windows systems and to"NUL"elsewhere.This allows to call for example
redirect_stdout(f, devnull)to supress all output tostdoutproduced in function callf().The first argument
fis still restricted to::Function.