Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove at-fastmath from base #36246

Open
musm opened this issue Jun 11, 2020 · 1 comment
Open

Remove at-fastmath from base #36246

musm opened this issue Jun 11, 2020 · 1 comment
Labels
maths Mathematical functions

Comments

@musm
Copy link
Contributor

musm commented Jun 11, 2020

Ref. comments from issue, which echo my feelings as well:

Getting rid of @fastmath might be good, not because of this issue, but because it's too loosely defined. People use it for all sort of different reasons (which all make code run "fast"). But before doing/evaluating that the replacement should go in first. e.g. #31862 and from the way people would like to use these this is certainly not trivial, and it'll likely always involve authors of the math function to do the right thing.
@yuyichao

There are other issues: @fastmath operates syntactically which can cause unexpected reults (#26828); --math-mode=fast doesn't do syntactic rewriting, instead just enables the compiler optimizations, which leads to other bizarre behavior (#30073). ..... Both are giant footguns.
@simonbyrne

It seems like this could only go in 2.0

@musm musm added the maths Mathematical functions label Jun 11, 2020
@StefanKarpinski
Copy link
Member

We could make it a no-op pre 2.0 though since code would still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maths Mathematical functions
Projects
None yet
Development

No branches or pull requests

2 participants