Make compilecache atomic #36416
Merged
Make compilecache atomic #36416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Jun 24, 2020
It would be good to cherry-pick that commit then so the original author gets credit. |
It's a set of commits, not one, and in a different repo. I'll add a 'Co-authored-by' line to the commit message instead. |
|
You can also commit as another author with |
When several Julia processes compile the same package concurrently (e.g. during a cluster run), they can conflict on the compile cache file. This change makes a Julia process create a compile cache in a temporary file and atomically rename it to the final cache file. Co-authored-by: Takafumi Arakaki <tkf@@users.noreply.github.com>
mbauman
added a commit
to dlfivefifty/julia
that referenced
this pull request
Jun 26, 2020
* origin/master: (232 commits) Add passthrough for non-Markdown docs (JuliaLang#36091) Fix pointer to no longer assume contiguity (JuliaLang#36405) Ensure string-hashing is defined before it gets used (JuliaLang#36411) Make compilecache atomic (JuliaLang#36416) add a test for JuliaLang#30739 (JuliaLang#36395) Fix broken links in docstring of `repeat` (JuliaLang#36376) fix and de-dup cached calls to `methods_by_ftype` in compiler (JuliaLang#36404) ml-matches: skip unnecessary work, when possible (JuliaLang#36413) gf: fix some issues with the move from using a tree to a hash lookup of leaf types (JuliaLang#36413) Add news and manual entry for sincospi (JuliaLang#36403) Check axes in Array(::AbstractArray) (fixes JuliaLang#36220) (JuliaLang#36397) add versions of `code_typed` and `which` that accept tuple types (JuliaLang#36389) Fix spelling of readdir. (JuliaLang#36409) add sincospi (JuliaLang#35816) fix showing methods with unicode gensymed variable names (JuliaLang#36396) Add doctest: eachslice (JuliaLang#36386) fix documentation typo ("Ingeger") Refactor `abstract_eval` to separate out statements and values (JuliaLang#36350) fix return type of `get!` on `IdDict` (JuliaLang#36383) Allow single option with REPL.TerminalMenus (JuliaLang#36369) ...
KristofferC
pushed a commit
that referenced
this pull request
Aug 3, 2020
When several Julia processes compile the same package concurrently (e.g. during a cluster run), they can conflict on the compile cache file. This change makes a Julia process create a compile cache in a temporary file and atomically rename it to the final cache file. Co-authored-by: Takafumi Arakaki <tkf@@users.noreply.github.com> (cherry picked from commit 3bbb582)
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
When several Julia processes compile the same package concurrently (e.g. during a cluster run), they can conflict on the compile cache file. This change makes a Julia process create a compile cache in a temporary file and atomically rename it to the final cache file. Co-authored-by: Takafumi Arakaki <tkf@@users.noreply.github.com>
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2020
When several Julia processes compile the same package concurrently (e.g. during a cluster run), they can conflict on the compile cache file. This change makes a Julia process create a compile cache in a temporary file and atomically rename it to the final cache file. Co-authored-by: Takafumi Arakaki <tkf@@users.noreply.github.com> (cherry picked from commit 3bbb582)
This was referenced Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #30174 and is identical except for additionally removing the temporary file code in
src/dump.c.