-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
active project: get rid of the concept of a home project #36434
Conversation
I need feedback on the idea more than the implementation (which I'm fairly confident about), but of course code review is always good to have as well. |
Perhaps best explained with an example. Without this PR:
Here
It's as if you'd started Julia without the |
So I was confused by this yesterday .. vscode starts the REPL with the home project in the current directory .. which probably makes sense (In Juno, you have to explicitly activate the primary project). But not having realised that, I found it very confusing why I could not get back to |
Don't recall needing this much so just removing it probably makes sense. |
Ok, seems like there's general support, so I'll add a NEWS entry and then merge this. |
Can we remove the |
This will break the Pkg tests so need to update there as well after this. |
Yeah, I have a PR to fix Pkg as well (just delete uses). Since it's not exported we can delete in 1.6 but I wanted to leave it so as not to break Pkg tests or cause tight coupling with this change and the necessary change in Pkg. |
This makes doing `julia --project` equivalent to activating the project that the current directory is in at Julia startup. What this means is that if you do `pkg> activate` instead of taking you back to whatever project was initially active, it will make it as if you had never activated a project in the first place.
9456316
to
ad0620f
Compare
NEWS added. |
Companion PR to remove all uses of HOME_PROJECT in Pkg: JuliaLang/Pkg.jl#1891; it also makes |
Same with IJulia which starts julia in the notebook dir, making it hard to go back to the root project. |
…6434) This makes doing `julia --project` equivalent to activating the project that the current directory is in at Julia startup. What this means is that if you do `pkg> activate` instead of taking you back to whatever project was initially active, it will make it as if you had never activated a project in the first place.
The concept of “home project” was removed in JuliaLang#36434.
The concept of “home project” was removed in JuliaLang/julia#36434. Also see JuliaLang#1891. Fixes JuliaLang#3127
The concept of “home project” was removed in #36434.
This makes doing
julia --project
equivalent to activating the project that the current directory is in at Julia startup. What this means is that if you dopkg> activate
instead of taking you back to whatever project was initially active, it will make it as if you had never activated a project in the first place.I think the "home project" idea is more confusing than it's worth and I do actually quite often want to deactivate the current project and get access to whatever the fallback active project would be, i.e.
@v1.6
, so this simpler version of this seems not only easier to explain but also more useful.cc @fredrikekre, @KristofferC