Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add intersect for CartesianIndices #36643

Merged
merged 2 commits into from
Jul 15, 2020
Merged

add intersect for CartesianIndices #36643

merged 2 commits into from
Jul 15, 2020

Conversation

stev47
Copy link
Contributor

@stev47 stev47 commented Jul 13, 2020

fixes #33055

@mbauman
Copy link
Member

mbauman commented Jul 13, 2020

Nice, thanks! I think we should do this, but it's perhaps worth noting that this changes the return type from a mutable Vector{CartesianIndex{N}} to an immutable N-dimensional CartesianIndices. I think nearly everyone who is using this will find it to be much more generally useful, and the fact that it's several complexity classes faster doesn't hurt, either.

@mbauman
Copy link
Member

mbauman commented Jul 13, 2020

It feels like a compat annotation would just make the docstring for intersect noisy, but I suppose it'd be nice to mention this in NEWS.

@mbauman mbauman added the needs news A NEWS entry is required for this change label Jul 13, 2020
@stev47 stev47 force-pushed the feature/cartesian-intersect branch from 21515cc to 7606525 Compare July 14, 2020 07:08
@stev47
Copy link
Contributor Author

stev47 commented Jul 14, 2020

Ok, I added the news entry. The timeout on aarch64 seems unrelated to me.

@mbauman mbauman removed the needs news A NEWS entry is required for this change label Jul 14, 2020
@JeffBezanson JeffBezanson merged commit 2850dfb into JuliaLang:master Jul 15, 2020
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
@stev47 @simeonschaub
add intersect for CartesianIndices (JuliaLang#36643)
cf6cbff
@OlivierHnt OlivierHnt mentioned this pull request Jun 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intersection of CartesianIndices
3 participants
@stev47 @mbauman @JeffBezanson