Add haskey(::RegexMatch, ::Symbol) to test for named capture groups
#36717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
approved these changes
Aug 3, 2020
Currently, the only way to test for a named capture group within `RegexMatch` is to attempt to index into it and catch the error after it fails; this adds a way to probe for a given key.
This error path is more helpfully handled by all call sites.
staticfloat
force-pushed
the
sf/regexmatch_haskey
branch
from
808b655
to
49a692d
Compare
|
@StefanKarpinski I reverted one of your return code checks because I didn't want to rely on exceptions in order to figure out if a named capture group does or does not exist. I hope that's okay; I checked that all call sites are properly dealing with that error code already. |
|
Sure, that's probably a good change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to test for a named capture group within
RegexMatchis to attempt to index into it and catch the error after itfails; this adds a way to probe for a given key.