Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upstream p7zip FreeBSD build fix patch #37332

Closed
StefanKarpinski opened this issue Sep 1, 2020 · 3 comments
Closed

upstream p7zip FreeBSD build fix patch #37332

StefanKarpinski opened this issue Sep 1, 2020 · 3 comments
Assignees
@ararslan
Labels
building Build system, or building Julia or its dependencies system:freebsd Affects only FreeBSD upstream The issue is with an upstream dependency, e.g. LLVM

Comments

@StefanKarpinski
Copy link
Member

https://github.com/JuliaLang/julia/blob/master/deps/patches/p7zip-Windows_ErrorMsg.patch

This patch should be upstreamed at https://sourceforge.net/projects/p7zip/
@StefanKarpinski StefanKarpinski added building Build system, or building Julia or its dependencies upstream The issue is with an upstream dependency, e.g. LLVM system:freebsd Affects only FreeBSD labels Sep 1, 2020
@StefanKarpinski StefanKarpinski mentioned this issue Sep 1, 2020
Closed
@ararslan
Copy link
Member

ararslan commented Sep 1, 2020

That file actually comes from the FreeBSD Ports Tree, and the patch was submitted there by @rakuco. Sorry to bother you, Raphael, but do you know whether there are existing plans to upstream this (or other) changes? If not, I can look into it.

@rakuco
Copy link

rakuco commented Sep 2, 2020

Hi there. Please feel free to try to upstream those changes -- the biggest problem is that p7zip as a project has barely had any activity in the past few years: the latest release is from 2016, and there isn't much going on in the bug/patch tracker. This bug report, for example, seems to be about the same issue that patch I landed fixes, and it's been ignored since last December.

@inkydragon
Copy link
Member

inkydragon commented Jun 19, 2022 •
edited
Loading

This is fixed by: jinfeihan57/p7zip@1b7d2c7

There are no more p7zip patches on the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ararslan ararslan

Labels
building Build system, or building Julia or its dependencies system:freebsd Affects only FreeBSD upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rakuco @StefanKarpinski @KristofferC @inkydragon @ararslan