Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Iterators.countfrom(::Any, ::Any) #37747

Merged
merged 5 commits into from
Sep 29, 2021
Merged

add Iterators.countfrom(::Any, ::Any) #37747

merged 5 commits into from
Sep 29, 2021

Conversation

MarcMush
Copy link
Contributor

@MarcMush MarcMush commented Sep 25, 2020 •
edited by stevengj
Loading

closes #37462

JeffBezanson
JeffBezanson approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@JeffBezanson JeffBezanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love ordinal types :)

@MarcMush MarcMush changed the title RFC: add Iterators.countfrom(::Any, ::Any) add Iterators.countfrom(::Any, ::Any) Oct 2, 2020
@MarcMush
Copy link
Contributor Author

@JeffBezanson can this be added for 1.6 ?

@StefanKarpinski
Copy link
Member

Bump?

@stevengj
Copy link
Member

Needs a NEWS item?

@stevengj stevengj added the needs news A NEWS entry is required for this change label Nov 16, 2020
@MarcMush
Copy link
Contributor Author

sorry for the delay, I added a NEWS entry

stevengj
stevengj reviewed Sep 27, 2021
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@stevengj stevengj removed the needs news A NEWS entry is required for this change label Sep 27, 2021
@stevengj stevengj added the merge me PR is reviewed. Merge when all tests are passing label Sep 27, 2021
vtjnash
vtjnash reviewed Sep 29, 2021
View reviewed changes
base/iterators.jl

eltype(::Type{Count{S}}) where {S} = S

eltype(::Type{Count{T,S}}) where {T,S} = T
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eltype(::Type{Count{T,S}}) where {T,S} = T
eltype(::Type{<:Count{T}}) where {T} = T

@vtjnash vtjnash removed the merge me PR is reviewed. Merge when all tests are passing label Sep 29, 2021
@oscardssmith oscardssmith merged commit 7f26a7f into JuliaLang:master Sep 29, 2021
oscardssmith added a commit that referenced this pull request Sep 29, 2021
@oscardssmith
Revert "add Iterators.countfrom(::Any, ::Any) (#37747)"
c340a01 
This reverts commit 7f26a7f.
@oscardssmith
Copy link
Member

I accidentally just merged this. Does it need to be reverted @vtjnash?

vtjnash added a commit that referenced this pull request Sep 29, 2021
@vtjnash
improve eltype of Count definition
c6a91c7 
Fixes review item #37747 (comment)
@vtjnash vtjnash mentioned this pull request Sep 29, 2021
Merged
KristofferC pushed a commit that referenced this pull request Sep 30, 2021
@vtjnash
improve eltype of Count definition (#42427)
6a335e3 
Fixes review item #37747 (comment)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@MarcMush @LilithHafner
add Iterators.countfrom(::Any, ::Any) (JuliaLang#37747)
5333e96
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@vtjnash @LilithHafner
improve eltype of Count definition (JuliaLang#42427)
85955ca 
Fixes review item JuliaLang#37747 (comment)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@MarcMush @LilithHafner
add Iterators.countfrom(::Any, ::Any) (JuliaLang#37747)
318357b
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@vtjnash @LilithHafner
improve eltype of Count definition (JuliaLang#42427)
829e42a 
Fixes review item JuliaLang#37747 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@JeffBezanson JeffBezanson JeffBezanson approved these changes

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iterators.countfrom(::Any, ::Any) doesn't exist
6 participants
@MarcMush @StefanKarpinski @stevengj @oscardssmith @vtjnash @JeffBezanson