-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more ergonomic stream redirection #37978
Conversation
CI fail looks related to PR. However I cannot reproduce this error locally. Ideas? |
What happens when you open the same file twice, and redirect stdout and stderr to the two descriptors? |
Ah, good spot. I need to make sure if |
I think freebsd CI fail is unrelated and this is ready to be reviewed. |
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
Can this be merged? |
Bump. |
@StefanKarpinski I am a bit surprised, that this needs triage. Anyway, I am glad that this PR gets some attention. How can I find out when the next triage session is? |
In general, any user facing change needs triage. This doesn't mean it's expected to be controversial, just that we don't want to be adding features carelessly. Triage meetings are (almost) every week at 14:30 EST on Thursdays. You're welcome to come, but don't feel like you need to. |
Bump! Is there interest in this? If so I can resolve the merge conflicts. |
Would be good to look at this on a triage call. |
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Can this be merged? Would love to have this in 1.7. |
bump |
Bump can this please be merged before 1.7 feature freeze? This PR was ready from my side before 1.6 feature freeze and it would be frustrating to miss 1.7 as well. |
Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Merge :)? |
@KristofferC can you merge this? |
I am glad, this could be merged before the feature freeze. Thanks, everybody! |
These were broken by JuliaLang/julia#37978 again.
These were broken by JuliaLang/julia#37978 again.
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com> Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com> Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Usually when I want to redirect
stdout
, I also want to redirectstderr
. And often I want to redirect them to some kind of logfile.This is quite a bit of boilerplate:
With this PR it is just