new readbytes and readbytes! functions #3878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request expands the functionality of the (internal)
readbytes
functions that we already had into two new (exported & documented) functions (inspired by the functionality in Python's RawIOBase class):The
readbytes!
function reads up tonb
bytes intobuffer
(growing it as needed), returning the number of bytes read. Thereadbytes
function reads up tonb
bytes and returns a new Vector{Uint8} buffer containing the bytes read.(Incidentally, we had two different implementations of
readall(s::IO)
, one replacing the other; I kept the one that usesreadbytes
.)PS. I added this functionality to make it easier for PyCall to pass Julia
IO
objects as the corresponding types in Python.