Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake JLL API discrepancies and usage concern #38781

Closed
fingolfin opened this issue Dec 8, 2020 · 0 comments · Fixed by #38797
Closed

Fake JLL API discrepancies and usage concern #38781

fingolfin opened this issue Dec 8, 2020 · 0 comments · Fixed by #38797
Assignees
Milestone

Comments

@fingolfin
Copy link
Contributor

I need to compile some C/C++ code on the user's machine -- yes, putting all code in a JLL would be nicer, but for various reasons that's not an option in this case.

This code needs to link against GMP. In the past, that was no problem, as GMP_jll provides all that is needed. But now master has switched to "fake JLLs" via PR #38347 by @staticfloat . This causes some issues. The first is that GMP_jll.find_artifact_dir() stopped working, but OK, I've reverted back to GMP_jll.artifact_dir.

More concerning to me is that I've downloaded the latest Julia nightlies builds -- and they do not contain gmp.h and gmpxx.h -- thus my use case is broken. Annoyingly this is not visible when using my own build of Julia master, as there the header files are of course present and even found by my code going through GMP_jll.

The only workaround I can think of right now is to bundle my own copies of those header files and hope they match the libgmp bundled with Julia. But perhaps Julia simply could bundle the header? I understand that you don't want to put those into include/julia/ but perhaps they could be stowed away somewhere else? E.g. there could be a dir lib/fake_jlls/GMP_jll/ with subdirs include (containing the actual gmp.h etc.) and lib (a relative symlink to the real lib dir)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants