Make cholmod preserve user-specified permutation #40560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ettersi
changed the title
ettersi
force-pushed
the
cholmod
branch
2 times, most recently
from
6d1fae8 to
fa9ed7f
Compare
|
Okay, now it seems to be working. Global state was taking me for a ride the first time around, so I changed the entire code base such that all changes to the |
ettersi
changed the title
|
Yikes, sorry about that conflict. Can you rebase? Also good to get a few more eyes on this. @andreasnoack perhaps. |
|
Rebase done! |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* Make cholmod preserve user-specified permutation * Ensure all changes to CHOLMOD.common are temporary * Fix spurious comment Co-authored-by: Simon Etter <ettersi@nus.edu.sg>
jarlebring
pushed a commit
to jarlebring/julia
that referenced
this pull request
May 4, 2021
* Make cholmod preserve user-specified permutation * Ensure all changes to CHOLMOD.common are temporary * Fix spurious comment Co-authored-by: Simon Etter <ettersi@nus.edu.sg>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* Make cholmod preserve user-specified permutation * Ensure all changes to CHOLMOD.common are temporary * Fix spurious comment Co-authored-by: Simon Etter <ettersi@nus.edu.sg>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* Make cholmod preserve user-specified permutation * Ensure all changes to CHOLMOD.common are temporary * Fix spurious comment Co-authored-by: Simon Etter <ettersi@nus.edu.sg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JuliaLang/LinearAlgebra.jl#649