Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should range(1, step=2, length=3)be a StepRangeLen? #40672

Open
simeonschaub opened this issue Apr 30, 2021 · 1 comment
Open

should range(1, step=2, length=3)be a StepRangeLen? #40672

simeonschaub opened this issue Apr 30, 2021 · 1 comment
Labels
domain:ranges Everything AbstractRange

Comments

@simeonschaub
Copy link
Member

This would eliminate the edge case of a step of zero resulting in an error and I don't see any major downsides of a StepRangeLen over a StepRange. It would also simplify the implementation in #40320.

Ref #40320 (comment)
cc @mcabbott
@simeonschaub simeonschaub added the domain:ranges Everything AbstractRange label Apr 30, 2021
@StefanKarpinski
Copy link
Sponsor Member

Seems good to me.

@sostock sostock mentioned this issue Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ranges Everything AbstractRange
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefanKarpinski @simeonschaub