Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round from zero support for non-BigFloats #41246

Merged
merged 14 commits into from
Apr 12, 2022
Merged

Round from zero support for non-BigFloats #41246

merged 14 commits into from
Apr 12, 2022

Conversation

jessymilare
Copy link
Contributor

My attempt to fix both #34519 and #41182.

Implements round(x, RoundFromZero), div(x, y, RoundFromZero) and friends.

mcabbott
mcabbott reviewed Jun 18, 2021
View reviewed changes
base/div.jl Outdated Show resolved Hide resolved
@kimikage kimikage mentioned this pull request Sep 10, 2021
Closed
@StefanKarpinski
Copy link
Member

This appears complete. Who needs to review this?

@oscardssmith oscardssmith added the maths Mathematical functions label Sep 10, 2021
oscardssmith
oscardssmith approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@oscardssmith oscardssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm pretty sure there is a more efficient way to do this rounding, but it's fine to add this with a less than optimal implementation, and improve it later if anyone cares enough.

mcabbott
mcabbott reviewed Sep 10, 2021
View reviewed changes
base/div.jl Show resolved Hide resolved
@StefanKarpinski
Copy link
Member

Have restarted CI since June 16th was a while ago.

@jessymilare jessymilare requested a review from a team as a code owner September 11, 2021 20:02
@jessymilare jessymilare force-pushed the round_from_zero branch 5 times, most recently from aba02cb to 3c2c95a Compare September 11, 2021 20:26
@jessymilare
Copy link
Contributor Author

jessymilare commented Sep 17, 2021 •
edited
Loading

Only failing on FreeBSD. Log only show a bunch of EOFErrors.

@stevengj
Copy link
Member

stevengj commented Apr 7, 2022

Fixed conflicts; hopefully this is good to go?

stevengj
stevengj reviewed Apr 7, 2022
View reviewed changes
base/div.jl Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Apr 7, 2022
View reviewed changes
base/div.jl Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Apr 7, 2022
View reviewed changes
base/div.jl Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Apr 7, 2022
View reviewed changes
base/div.jl Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Apr 7, 2022
View reviewed changes
base/rounding.jl Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Apr 7, 2022
View reviewed changes
base/rounding.jl Outdated Show resolved Hide resolved
@stevengj stevengj added triage This should be discussed on a triage call merge me PR is reviewed. Merge when all tests are passing and removed triage This should be discussed on a triage call labels Apr 7, 2022
giordano
giordano reviewed Apr 9, 2022
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@DilumAluthge DilumAluthge removed the request for review from a team April 12, 2022 02:03
@DilumAluthge DilumAluthge merged commit c2da085 into JuliaLang:master Apr 12, 2022
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Apr 12, 2022
This was referenced Feb 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcabbott mcabbott mcabbott left review comments

@giordano giordano giordano left review comments

@oscardssmith oscardssmith oscardssmith approved these changes

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
maths Mathematical functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jessymilare @StefanKarpinski @stevengj @giordano @oscardssmith @mcabbott @DilumAluthge