compiler: speed up bootstrapping time by 25% #41794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimizer code is full of loop constructions and I found they're really better to not run in interpreter. With this PR, we create the caches of the optimizer code first and it speeds up the succeeding bootstrapping to create the caches for the overall inference code. On my machine, the bootstrapping took about 80 seconds previously, but on this PR the time is reduced to about 60 seconds.
|
I don't fully understand this, but I'll gladly take 20 second faster CI! |
vtjnash
approved these changes
Aug 5, 2021
| @@ -5,10 +5,20 @@ | |||
| # especially try to make sure any recursive and leaf functions have concrete signatures, | |||
| # since we won't be able to specialize & infer them at runtime | |||
|
|
|||
| let fs = Any[typeinf_ext, typeinf, typeinf_edge, pure_eval_call, run_passes], | |||
There was a problem hiding this comment.
I noticed that besides reordering, pure_eval_call has been removed. How come that it isn't needed anymore?
There was a problem hiding this comment.
pure_eval_call can be easily inferred from the entries like typeinf, because we make sure Core.Compiler is very type stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimizer code is full of loop constructions and I found they're
really better to not run in interpreter.
With this PR, we create the caches of the optimizer code first and
it speeds up the succeeding bootstrapping to create the caches for
the overall inference code.
On my machine, the bootstrapping took about 80 seconds previously,
but on this PR the time is reduced to about 60 seconds.