Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AVX2 and BMI2 instructions #4418

Closed
ihnorton opened this issue Oct 2, 2013 · 6 comments · Fixed by #5208
Closed

Support AVX2 and BMI2 instructions #4418

ihnorton opened this issue Oct 2, 2013 · 6 comments · Fixed by #5208
Labels
upstream The issue is with an upstream dependency, e.g. LLVM

Comments

@ihnorton
Copy link
Member

ihnorton commented Oct 2, 2013

Reminder to revert the temporary fix for #4362.

Related LLVM bug: http://llvm.org/bugs/show_bug.cgi?id=17422

This would likely be subsumed by switching to MCJIT.

See also a similar bug in AVX support, resolved by backporting some functionality from MCJIT.

@Keno
Copy link
Member

Keno commented Oct 2, 2013

The LLVM folks have been actively trying to push people off the legacy JIT, but I'm not sure we can support MCJIT before they implement multi-module support. It does seem like that is underway at the moment though, so maybe just stay put until that is resolved.

@blakejohnson
Copy link
Contributor

It may be worth keeping this open until we have removed the cases where we disabled AVX2 and BMI2.

@JeffBezanson JeffBezanson reopened this Jan 17, 2014
@Keno Keno self-assigned this Jun 3, 2014
@ViralBShah ViralBShah added this to the 0.4 milestone Jun 6, 2014
@vtjnash vtjnash removed this from the 0.4.x milestone Jul 31, 2015
@JeffBezanson
Copy link
Member

Bump. Can we remove the workaround now?

@vtjnash vtjnash closed this as completed May 13, 2016
@vtjnash
Copy link
Member

vtjnash commented May 13, 2016

it's been conditional on the llvm version for a long time, I just don't feel like doing blame to check which commit did it

@kmsquire
Copy link
Member

Just for documentation: workaround is here: https://github.com/JuliaLang/julia/blob/master/src/codegen.cpp#L5635-L5639

I don't see a condition on LLVM version, but maybe I missed it...?

@vtjnash
Copy link
Member

vtjnash commented May 13, 2016

#ifndef USE_MCJIT is a fake-version test since it is always false for llvm < 3.4 and always true for llvm > 3.4 (that excludes 3.4, but it's JIT options were broken anyhow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants