-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphemes(s, m:n) substring slicing #44266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
added
strings
"Strings!"
unicode
Related to unicode characters and encodings
labels
Feb 19, 2022
Should anything be said about the time complexity of this operation in the docstring? |
Sure, added. |
buildkite CI errors seem unrelated:
and
and
|
sostock
reviewed
Feb 21, 2022
Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
stevengj
force-pushed
the
sgj/graphemeslice
branch
from
March 31, 2022 21:52
54ce012
to
df67e76
Compare
Isn't it a bit confusing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People seem to want this functionality, and it's nontrivial to implement efficiently & correctly.
(Discoverability is a challenge here, because most people wanting to access a "slice of characters" in Unicode probably don't know what a grapheme is, but at least this gives us a succinct answer to such questions.)