Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile tests broken on aarch64 #45065

Closed
staticfloat opened this issue Apr 23, 2022 · 6 comments
Closed

Profile tests broken on aarch64 #45065

staticfloat opened this issue Apr 23, 2022 · 6 comments
Labels
ci Continuous integration system:arm ARMv7 and AArch64 system:linux Affects only Linux

Comments

@staticfloat
Copy link
Member

Hot new results fresh off of the buildkite presses: https://buildkite.com/julialang/julia-buildkite/builds/532#4f193e60-7596-4547-8770-fe803022e9cd/429-905

Profile                                   (8) |         failed at 2022-04-23T03:57:25.790
Test Failed at /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Profile/test/runtests.jl:56
  Expression: !(isempty(String(take!(iobuf))))
   Evaluated: !(isempty(""))
Test Failed at /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Profile/test/runtests.jl:70
  Expression: !(isempty(String(take!(iobuf))))
   Evaluated: !(isempty(""))
Test Failed at /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Profile/test/runtests.jl:70
  Expression: !(isempty(String(take!(iobuf))))
   Evaluated: !(isempty(""))
Test Failed at /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Profile/test/runtests.jl:70
  Expression: !(isempty(String(take!(iobuf))))
   Evaluated: !(isempty(""))
Test Failed at /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Profile/test/runtests.jl:70
  Expression: !(isempty(String(take!(iobuf))))
   Evaluated: !(isempty(""))
Test Failed at /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Profile/test/runtests.jl:70
  Expression: !(isempty(String(take!(iobuf))))
   Evaluated: !(isempty(""))
Error During Test at /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Profile/test/runtests.jl:165
  Test threw exception
  Expression: getline(values(fdictc)) == getline(values(fdict0)) + 2
  MethodError: no method matching +(::Nothing, ::Int64)
  Closest candidates are:
    +(::Any, ::Any, !Matched::Any, !Matched::Any...) at operators.jl:578
    +(!Matched::T, ::T) where T<:Union{Int128, Int16, Int32, Int64, Int8, UInt128, UInt16, UInt32, UInt64, UInt8} at int.jl:87
    +(!Matched::Main.Test16Main_compiler_irpasses.Bar29983{S}, ::T) where {T, S} at /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/test/compiler/irpasses.jl:624
    ...
  Stacktrace:
   [1] macro expansion
     @ /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Test/src/Test.jl:464 [inlined]
   [2] macro expansion
     @ /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Profile/test/runtests.jl:165 [inlined]
   [3] macro expansion
     @ /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Test/src/Test.jl:1360 [inlined]
   [4] top-level scope
     @ /cache/build/default-armageddon-4/julialang/julia-buildkite/julia-3cff21e725/share/julia/stdlib/v1.9/Profile/test/runtests.jl:151

@staticfloat staticfloat added system:linux Affects only Linux system:arm ARMv7 and AArch64 labels Apr 23, 2022
@gbaraldi
Copy link
Member

I can't reproduce on an ampere instance

ulia> Base.runtests(["Profile"])
Running parallel tests with:
  nworkers() = 1
  nthreads() = 1
  Sys.CPU_THREADS = 2
  Sys.total_memory() = 23.433 GiB
  Sys.free_memory() = 22.557 GiB

Test  (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
Profile    (1) |        started at 2022-04-23T11:47:07.038
Profile    (1) |    64.77 |   0.40 |  0.6 |    1667.54 |  1284.94

Test Summary: | Pass  Total     Time
  Overall     |  113    113  1m06.2s
    SUCCESS

julia> versioninfo()
Julia Version 1.9.0-DEV.428
Commit 3cff21e725* (2022-04-22 01:46 UTC)
Platform Info:
  OS: Linux (aarch64-linux-gnu)
  CPU: 4 × Neoverse-N1
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, neoverse-n1)
  Threads: 1 on 4 virtual cores

@giordano
Copy link
Contributor

On a MacBook M1 with Asahi Linux I get a different failure:

julia> Base.runtests(["Profile"])
Running parallel tests with:
  nworkers() = 1
  nthreads() = 1
  Sys.CPU_THREADS = 4
  Sys.total_memory() = 15.148 GiB
  Sys.free_memory() = 12.426 GiB

Test  (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
Profile    (1) |        started at 2022-04-24T17:35:06.851
Profile    (1) |         failed at 2022-04-24T17:35:41.411
Test Failed at /home/mose/repo/julia/usr/share/julia/stdlib/v1.9/Profile/test/runtests.jl:80
  Expression: data_without[1] == data_with[1]
   Evaluated: 0x0000000000000000 == 0x0000000000000001


Test Summary: | Pass  Fail  Total   Time
  Overall     |  112     1    113  35.2s
    Profile   |  112     1    113  34.8s
    FAILURE

The global RNG seed was 0x806f74d9334dc6969fa021a063c3f3cd.

Error in testset Profile:
Test Failed at /home/mose/repo/julia/usr/share/julia/stdlib/v1.9/Profile/test/runtests.jl:80
  Expression: data_without[1] == data_with[1]
   Evaluated: 0x0000000000000000 == 0x0000000000000001
ERROR: LoadError: Test run finished with errors
in expression starting at /home/mose/repo/julia/usr/share/julia/test/runtests.jl:93
ERROR: A test has failed. Please submit a bug report (https://github.com/JuliaLang/julia/issues)
including error messages above and the output of versioninfo():
Julia Version 1.9.0-DEV.431
Commit 45abec434a (2022-04-24 01:46 UTC)
Platform Info:
  OS: Linux (aarch64-unknown-linux-gnu)
  CPU: 8 × unknown
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, apple-m1)
  Threads: 1 on 8 virtual cores

@IanButterworth
Copy link
Member

What's different about the buildbot and buildkite aarch64 machines, given tester_linuxaarch64 doesn't fail?

@staticfloat
Copy link
Member Author

staticfloat commented Apr 27, 2022

They are the same machine. :(

One difference is that we're running inside of a sandbox, another difference is that we're running as a child of the buildkite process, which may setup certain things differently.

@giordano giordano added the ci Continuous integration label Jul 11, 2022
@ViralBShah
Copy link
Member

I believe this is ok now, but please reopen if not.

@gbaraldi
Copy link
Member

gbaraldi commented Sep 5, 2022

I haven't seen it in a while, so it seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration system:arm ARMv7 and AArch64 system:linux Affects only Linux
Projects
None yet
Development

No branches or pull requests

5 participants