Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version_git.jl line 16 on julia 1.6.6 and julia 1.7.2 #45100

Open
paolo-oliveri opened this issue Apr 26, 2022 · 2 comments
Open

Wrong version_git.jl line 16 on julia 1.6.6 and julia 1.7.2 #45100

paolo-oliveri opened this issue Apr 26, 2022 · 2 comments

Comments

@paolo-oliveri
Copy link

Hello,
I have found an issue in packages distributed using the releases download or the Source download of the Julia site.
There is a git information julia script called version_git.jl in the base directory, that I think it is created by version_git.sh
There is an option of "NO_GIT" in version_git.sh that echoes in version_git.jl the following line:

const GIT_VERSION_INFO = GitVersionInfo("" ,"" ,"" ,0 ,"" ,true ,0 ,0.)

Unfortunately, the Struct VersionInfo has 10 entries and during make the compilation will fail with MethodError.
To resolve this issue one can edit version_git.sh at line 27 by adding two more empty string entries at the right of the last 0 in the GitVersionInfo call.

This issue is not present in the master branch as it is already resolved, but if one downloads the stable or LTS branch and tries to compile he will ecounter it for sure.
Sincerely,
Paolo Oliveri

@giordano
Copy link
Contributor

giordano commented Apr 26, 2022

To be clear, are you talking about issue #43716, which was fixed by #43717? There is no way to retroactively change a released version: they're supposed to be immutable once they're out. The fix could be backported to the v1.6 branch, but in any case you'll never see the fix in v1.6.6 as is.

@paolo-oliveri
Copy link
Author

Hello,
thank you for your response.
Yes, it is the issue you mention.
I am aware that the stable and LTS versions are supposed to be immutable, I only wanted to remind that the two versions that ship in the website as downloadable and buildable source code cannot be built so easily without this modification in the code!
Sincerely,
Paolo Oliveri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants