Windows REPL autocomplete gets mixed up

[ncnc]

Within the ordinary Windows REPL (i.e. running julia.bat), autocomplete initially works:

julia> Pkg.\t
Pkg.Cache               Pkg._resolve            Pkg.installed
Pkg.Dir                 Pkg.add                 Pkg.isrewritable
<snip>
julia> Pkg.

However, if I run any other command first the REPL no longer responds to the tab key, I also need to press enter for the autocomplete info to appear:

julia> 1+1
2

julia> Pkg.\t\r\n
Pkg.
Pkg.Cache               Pkg._resolve            Pkg.installed
Pkg.Dir                 Pkg.add                 Pkg.isrewritable
<snip>

Edit: Just came to think of it, some other commands also seem to leave hanging around waiting for an extra enter key.

[ncnc]

I don't claim to understand the repl code, but the following "wrong" change seems to make things work again.

jl_deprep_terminal() gets called between all input lines and apparently turns i/o from raw to cooked on Windows. It looks like the corresponding code in jl_prep_terminal() sets everything back to raw, but the repl behaves like it gets stuck in cooked mode, for some reason.

diff --git a/ui/repl-readline.c b/ui/repl-readline.c
index 2e8e5bb..b424f3e 100644
--- a/ui/repl-readline.c
+++ b/ui/repl-readline.c
@@ -813,7 +813,7 @@ void jl_deprep_terminal ()
     rl_deprep_terminal();
     rl_instream = rl_in;
 #ifdef __WIN32__
-    if (jl_uv_stdin->type == UV_TTY) uv_tty_set_mode((uv_tty_t*)jl_uv_stdin,0); // cooked
+    //if (jl_uv_stdin->type == UV_TTY) uv_tty_set_mode((uv_tty_t*)jl_uv_stdin,0); // cooked
 #endif
 }

[ncnc]

I digged some more and libuv seems to do everything right as far as I can tell, I don't see why it's not working.

I'm running on Windows 8 (64 bit Windows, 32 bit Julia). I was going to try it out on a WinXP machine, but I gave up after seeing some dbghelp.dll version issues (I'm opening a separate issue).

It would be interesting to know if anybody else sees this problem?

[pao]

but I gave up after seeing some dbghelp.dll version issues (I'm opening a separate issue).

Please don't until you've read #4419, which is almost certainly the same thing.

[simonster]

@StefanKarpinski reported similar problems in #4357, although since I could reproduce this issue on OS X without that PR I think the cause might be #2056. I'm not sure if it's worth trying to fix this before REPL.jl.

[vtjnash]

Setting uv_tty_set_mode does a lot more than just configure the terminal: it also installs read/write hooks so that terminal formatting and utf8 characters come through correctly. Something in all that logic could be getting confused.

[ncnc]

I finally got around to trying out Julia on a WinXP machine. To my surprise the REPL autocomplete worked perfectly fine. There seems to be a difference in console behavior between WinXP and later versions, likely related to the SetConsoleMode() call.

The discussion here suggests a possible solution.

As the current REPL is soon-to-be obsolete I suppose this isn't much of a priority, but I'll leave the issue open until the new REPL is enabled.

[ncnc]

This issue seems to have been fixed for me by #5973, so I'm closing it. Thanks.

[vtjnash]

Sounds good. Yes that commit made the repl parsing much happier