Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In .ji files, paths should be depot-relative (not absolute) #45215

Closed
DilumAluthge opened this issue May 7, 2022 · 0 comments · Fixed by #49866
Closed

In .ji files, paths should be depot-relative (not absolute) #45215

DilumAluthge opened this issue May 7, 2022 · 0 comments · Fixed by #49866
Labels
compiler:precompilation Precompilation of modules filesystem Underlying file system and functions that use it packages Package management and loading

Comments

@DilumAluthge
Copy link
Member

DilumAluthge commented May 7, 2022

Cross-ref: #47943

Right now, in .ji files, we embed absolute file paths. We should instead embed file paths that are relative (with respect to the depot in which the precompile cache is located).

Motivation

We want to be able to move the depot without invalidating all .ji files in the precompile cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:precompilation Precompilation of modules filesystem Underlying file system and functions that use it packages Package management and loading
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant