Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max() vs. maximum() #4652

Closed
goszlanyi opened this issue Oct 26, 2013 · 1 comment
Closed

max() vs. maximum() #4652

goszlanyi opened this issue Oct 26, 2013 · 1 comment
Labels
won't change Indicates that work won't continue on an issue or pull request

Comments

@goszlanyi
Copy link

I may be late and I cannot find when it was decided,
but I feel that if there should be separate names for max() and maximum(),
then these names should be chosen the other way around.

In my code max(iterable collection) occurs much more frequently
than the multiargument version max(arg1,arg2,...),
and other functions like indmax() and findmax() also relate better.

I have just tested 0.2.0-rc2 and experienced the large number of depreciation warnings
in Winston due to the recent change of max() to maximum() for iterable collection arguments.
Of course Winston and other packages will make this renaming
but the sheer number of occurrences clearly show that the short name max()
is better suited for iterable collections.

Thank you for your consideration.

@StefanKarpinski
Copy link
Member

There was a long, involved discussion about this: #4235. The current naming is linguistically the least confusing: you take the min of a and b but you find the minimum of a vector or a matrix. The names indmax and findmax are not great anyway, so yeah, maybe some of those need to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't change Indicates that work won't continue on an issue or pull request
Projects
None yet
Development

No branches or pull requests

2 participants