Dates: Error on construction/parsing with empty strings #47117
Conversation
When attempting to construct a `DateTime`, `Date` or `Time` from an `AbstractString`, throw an `ArgumentError` if the string is empty. Likewise, error when `parse`ing an empty string as one of these types, and return `nothing` from `tryparse`. This behavior differs from previously. Before, `Date` and `Time` would return default values of `Date(1)` and `Time(0)`, respectively, while `DateTime` would error without a `format` argument. With a `format` argument, it would return `DateTime(1)`. However, this appears not to have been explicitly intended, but rather a consequence of the way parsing was implemented; no tests for empty string parsing existed. This addresses JuliaLang#28090 and JuliaLang#43883; see discussion therein. Summary of changes: - Check for empty string in `Base.parse(::DateTime)` and throw if so. - Change documentation to mention this. - Add a compat notice to the docs contrasting the old behavior.
anowacki
force-pushed
the
an/dates-empty-string-parsing
branch
from
40e1d33 to
a0a9988
Compare
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
|
I'm not experienced in reading the output of PkgEval, but I can't personally see anything Dates-related in any of the failures. (Parsers.jl has Dates-related tests which still pass.) So it may be safe to say no registered packages have tests which rely on parsing empty strings as valid |
|
It seems Parsers.jl already errored on these cases so I doubt there is much of a change there. I get EOF errors. |
Parsers.jl has it's own re-implementation of Date parsing since the last major version release, so no issues there. |
|
Actually, testing all the 'failing' packages locally with this PR shows them passing, so I'm confident the failures are totally unrelated. |
|
So just merge this? |
|
@KristofferC anything more needed to make a decision here, or are discussions ongoing? I'm happy to help in any way. |
When attempting to construct a `DateTime`, `Date` or `Time` from an `AbstractString`, throw an `ArgumentError` if the string is empty. Likewise, error when `parse`ing an empty string as one of these types, and return `nothing` from `tryparse`. This behavior differs from previously. Before, `Date` and `Time` would return default values of `Date(1)` and `Time(0)`, respectively, while `DateTime` would error without a `format` argument. With a `format` argument, it would return `DateTime(1)`. However, this appears not to have been explicitly intended, but rather a consequence of the way parsing was implemented; no tests for empty string parsing existed. This addresses #28090 and #43883; see discussion therein. Summary of changes: - Check for empty string in `Base.parse(::DateTime)` and throw if so. - Change documentation to mention this. - Add a compat notice to the docs contrasting the old behavior.
This PR is an RFC relating to the discussion in #43883. It is
meant to be used to help in making the decision whether the change
can be made in a minor Julia release, or really does need to
wait for a major version change. The commit message follows:
When attempting to construct a
DateTime,DateorTimefrom anAbstractString, throw anArgumentErrorif the string is empty.Likewise, error when
parseing an empty string as one of these types,and return
nothingfromtryparse.This behavior differs from previously. Before,
DateandTimewouldreturn default values of
Date(1)andTime(0), respectively, whileDateTimewould error without aformatargument. With aformatargument, it would return
DateTime(1). However, this appears not tohave been explicitly intended, but rather a consequence of the way
parsing was implemented; no tests for empty string parsing existed.
This addresses #28090 and #43883; see discussion therein.
Summary of changes:
Base.parse(::DateTime)and throw if so.