Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate mapslices #47793

Open
ParadaCarleton opened this issue Dec 3, 2022 · 0 comments
Open

Deprecate mapslices #47793

ParadaCarleton opened this issue Dec 3, 2022 · 0 comments
Labels
breaking This change will break code

Comments

@ParadaCarleton
Copy link
Contributor

ParadaCarleton commented Dec 3, 2022 •
edited
Loading

Related to #16606, there's no longer a need for mapslices (or any of the dims arguments for reducing functions) now that that eachslice is type-stable (and has a much nicer+more consistent syntax); I'd argue we should remove it in 2.0, deprecating it for map(eachslice(x; dims=...)).
@ParadaCarleton ParadaCarleton changed the title A new slicing interface (2.0) Deprecate mapslices Dec 3, 2022
@brenhinkeller brenhinkeller added the breaking This change will break code label Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This change will break code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brenhinkeller @ParadaCarleton