-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not require a git repository to build and install #5068
Comments
CC @staticfloat |
@ivarne that sounds fine to me. Moving it out to a @nalimilan I would review a pull request for a makevar such as |
@staticfloat I think I'd prefer a solution where |
Very similar to #2539 |
I think this can be closed now. |
Currently packagers need to carry patches to disable git when building Julia:
https://github.com/staticfloat/julia-nightly-packaging/blob/master/build_ubuntu.sh#L51-87
I also needed to patch deps/Makefile (and Debian does something similar) so that I can provide a tarball instead of using the git submodule for libuv:
https://gist.github.com/nalimilan/7863923
Of course since this is an unofficial version of libuv, but for packaging it's much better to get a tarball from Github using an URL such as
https://github.com/JuliaLang/libuv/archive/%{uvcommit}/archive/libuv-%{uvversion}-%{uvshortcommit}.tar.gz
This way stable sources can be downloaded by anybody simply having access to the package control file.
Thus, it would be nice if the Makefile could check whether a tarball for libuv is present before trying to use the git submodule. Or maybe a global switch could be enabled when make detects that the build is happening from a tarball rather than a git repository?
The text was updated successfully, but these errors were encountered: