Specialized solvers for Diagonal matrices #5263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge after rebasing from #5255 and code review |
| end | ||
|
|
||
| #Generic solver using naive substitution | ||
| function naivesub!(A::Triangular, b::AbstractVector, x::AbstractVector=b) |
There was a problem hiding this comment.
Why not A_ldiv_B!? I would also prefer overwriting the right hand side. It is more in line with BLAS.
|
The |
|
Indeed it shouldn't; however, I developed this branch off |
- New subtraction, scalar multiplication, division methods - New linear solver, eigensystem solver, singular solver methods
jiahao
added a commit
that referenced
this pull request
Jan 1, 2014
Specialized solvers for Diagonal matrices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides generic linear solvers, eigensystem solvers and singular value solvers for Diagonal matrices.
Where possible, the tests go beyond the standard
BlasFloatnumeric types to includeFloat16,BigFloatand their complex analogues.