Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most packages with artifacts are not relocatable #54398

Closed
jonathan-conder-sm opened this issue May 8, 2024 · 4 comments · Fixed by #54426
Closed

Most packages with artifacts are not relocatable #54398

jonathan-conder-sm opened this issue May 8, 2024 · 4 comments · Fixed by #54426

Comments

@jonathan-conder-sm
Copy link
Contributor

Would anything break if I added track_content = true to this line?

Base.include_dependency(artifacts_toml)

Related: #53906 and/or #51798

@KristofferC
Copy link
Member

I don't see why anything should break.

@vchuravy
Copy link
Member

vchuravy commented May 9, 2024

@jonathan-conder-sm do you want to open that PR?

@jonathan-conder-sm
Copy link
Contributor Author

Sure, sorry I've been busy and forgot about this. See #54426

I'm curious, if this is unlikely to break anything then why is track_content not the default?

@fatteneder
Copy link
Member

fatteneder commented May 10, 2024

The default track_content = false was initially chosen, because that's how it used to work before. In particular, some folks on discourse, and I think also Oscar.jl, relied on the mtime check to trigger recompilation.
Admittedly, its a moot argument, because we already changed the behavior for include away from using mtime, and it was also changed how include_dependency itself deals with directories.

I think that not many pkgs would notice the change, because its seldomly used.
If someone would stand up to represent this as a bug fix, then I guess we could change the default to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants