Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension check too restrictive in copytrito! and lacpy! #54546

Closed
amontoison opened this issue May 22, 2024 · 0 comments · Fixed by #54587
Closed

Dimension check too restrictive in copytrito! and lacpy! #54546

amontoison opened this issue May 22, 2024 · 0 comments · Fixed by #54587
Labels
linear algebra Linear algebra

Comments

@amontoison
Copy link
Contributor

In #51909, I interfaced copytri! and lacpy!, but I didn't test them on rectangular matrices. The check:

(m1 < m || n1 < n) && throw(DimensionMismatch(lazy"B of size ($m1,$n1) should have at least the same number of rows and columns as A of size ($m,$n)"))

is too restrictive in two cases.

  1. If A has more rows than columns and uplo = 'U', B only needs to be p x p, where p is the number of columns of A. A common application of this is performing a reduced QR on A.

  2. Similarly, if A has more columns than rows and uplo = 'L', B only needs to be t x t, where t is the number of rows of A. This is relevant when performing a reduced LQ on A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants