You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #51909, I interfaced copytri! and lacpy!, but I didn't test them on rectangular matrices. The check:
(m1 < m || n1 < n) &&throw(DimensionMismatch(lazy"B of size ($m1,$n1) should have at least the same number of rows and columns as A of size ($m,$n)"))
is too restrictive in two cases.
If A has more rows than columns and uplo = 'U', B only needs to be p x p, where p is the number of columns of A. A common application of this is performing a reduced QR on A.
Similarly, if A has more columns than rows and uplo = 'L', B only needs to be t x t, where t is the number of rows of A. This is relevant when performing a reduced LQ on A.
The text was updated successfully, but these errors were encountered:
In #51909, I interfaced
copytri!
andlacpy!
, but I didn't test them on rectangular matrices. The check:is too restrictive in two cases.
If
A
has more rows than columns anduplo = 'U'
,B
only needs to bep x p
, wherep
is the number of columns ofA
. A common application of this is performing a reduced QR onA
.Similarly, if
A
has more columns than rows anduplo = 'L'
,B
only needs to bet x t
, wheret
is the number of rows ofA
. This is relevant when performing a reduced LQ onA
.The text was updated successfully, but these errors were encountered: